Github user revans2 commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/128#discussion_r13385421
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/common/security/HdfsSecurityUtil.java
---
@@ -0,0 +1,48 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.hdfs.common.security;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.security.SecurityUtil;
+import org.apache.hadoop.security.UserGroupInformation;
+
+import java.io.IOException;
+import java.util.Map;
+
+/**
+ * This class provides util methods for storm-hdfs connector communicating
+ * with secured HDFS.
+ */
+public class HdfsSecurityUtil {
+ public static final String STORM_KEYTAB_FILE_KEY = "storm.keytab.file";
+ public static final String STORM_USER_NAME_KEY =
"storm.kerberos.principal";
+
+ public static void login(Map conf, Configuration hdfsConfig) throws
IOException {
+ if (UserGroupInformation.isSecurityEnabled()) {
--- End diff --
With our previous discussion about shipping configs packaged in the jar vs
as a part of the topology conf and then populating a Hadoop Configuration.
This is one of those places where some of the config really has to be on the
class path, and cannot be a part of the topology conf. UserGroupInformation
internally is creating a new Configuration that will only search the class path
and pull in configs it finds. It then uses that config to decide if security
is enabled. If you don't have a core-site.xml that is configured with
security, it will never think you have security turned on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
