Github user miguno commented on the pull request:
https://github.com/apache/incubator-storm/pull/103#issuecomment-45448273
FYI: I'll add Nathan's comment on our test methodology to DEVELOPER.md.
> On 07.06.2014, at 20:59, Nathan Marz <[email protected]> wrote:
>
> -1 Tests should never, ever rely on timing in order to pass. This is the
whole reason for doing time simulation in the first place, so that when
functionality depends on time it can be properly tested without having to worry
about random delays messing up the tests.
>
> complete-topology is inherently reliant on detecting topology completion
based on the spout saying all its tuples are "complete". If you're testing
topologies that don't do full tuple acking, then you should be testing using
the "tracked topologies" utilities in backtype.storm.testing.clj
>
> For example, here is how the acking system is tested using tracked
topologies:
https://github.com/apache/incubator-storm/blob/master/storm-core/test/clj/backtype/storm/integration_test.clj#L213
>
> The "tracked-wait" function is the key which will only return when both
that many tuples have been emitted by the spouts AND the topology is idle (no
tuples have been emitted nor will be emitted without further input) You
shouldn't use tracked-topologies for topologies that have tick tuples, but that
shouldn't be a problem in this case.
>
> â
> Reply to this email directly or view it on GitHub.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
