Github user d2r commented on the pull request:
https://github.com/apache/incubator-storm/pull/130#issuecomment-45632088
Having code style standards is a good idea, and I'm for it.
* No objection to the style chosen.
* With this change, there is a git-blame "barrier." Say I am searching for
the revision a particular change was made: It seems to me I will hit this
commit for a large amount of the lines in the clojure source instead of
locating the commit where the last non-formatting change was made. Anyone know
a way around this or a better way of locating a commit for a particular line of
code?
* To practically help with compliance to this standard, is there an
automated tool we could use to validate changes or is it up to the reviewers to
manually do this?
* One tiny spelling comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
