Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/139#discussion_r13763330
  
    --- Diff: storm-core/src/clj/backtype/storm/util.clj ---
    @@ -412,6 +404,41 @@
     (defn sleep-until-secs [target-secs]
       (Time/sleepUntil (* (long target-secs) 1000)))
     
    +(def ^:const sig-kill 9)
    +
    +(def ^:const sig-term 15)
    +
    +(defn send-signal-to-process [pid signum]
    --- End diff --
    
    With the new coding guidelines, could you put the parameter list on a 
separate line?
    
    ```
    (defn send-signal-to-process
      [pid signum]
      ...)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to