[
https://issues.apache.org/jira/browse/STORM-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14030920#comment-14030920
]
ASF GitHub Bot commented on STORM-351:
--------------------------------------
GitHub user ptgoetz opened a pull request:
https://github.com/apache/incubator-storm/pull/141
STORM-351: fix logic for writing offsets to ZooKeeper
Should be self-explanatory from the diff.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ptgoetz/incubator-storm STORM-351
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/141.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #141
----
commit 6f9a67385cf5418b7ae9c6b1896dc573c5ec8a3b
Author: P. Taylor Goetz <[email protected]>
Date: 2014-06-13T18:01:32Z
STORM-351: fix logic for writing offsets to ZooKeeper
----
> multilang python process fall into endless loop
> -----------------------------------------------
>
> Key: STORM-351
> URL: https://issues.apache.org/jira/browse/STORM-351
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Affects Versions: 0.9.3-incubating
> Environment: storm 0.9.3-incubating
> Reporter: DashengJu
> Priority: Blocker
>
> 1. steps to reproduce
> 1) write a topology with a python bolt, run the topology on storm; then
> there will be two process for the bolt: the worker(java process for
> ShellBolt), python process.
> 2)kill -9 the worker(java process for ShellBolt);
> 2. expected behavior
> the worker exit and the python process exist
> 3. actual, incorrect behavior
> the worker exit, but the python process never exist and fall into endless
> loop
> 4. analyse
> in storm.py,read tuple from stdin with follow function:
> def readMsg():
> msg = ""
> while True:
> line = sys.stdin.readline()[0:-1]
> if line == "end":
> break
> msg = msg + line + "\n"
> return json_decode(msg[0:-1])
> when sys.stdin is closed, EOF is encountered, readline() return None, so
> readMsg fall into endless loop.
--
This message was sent by Atlassian JIRA
(v6.2#6252)