[
https://issues.apache.org/jira/browse/STORM-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14030950#comment-14030950
]
ASF GitHub Bot commented on STORM-352:
--------------------------------------
GitHub user ptgoetz opened a pull request:
https://github.com/apache/incubator-storm/pull/142
STORM-352: fix logic for writing offsets to ZooKeeper
`lastCompletedOffset != lastCompletedOffset`
should be:
`_committedTo != lastCompletedOffset`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ptgoetz/incubator-storm STORM-352
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/142.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #142
----
commit 57851bb6be4caec950541bcb1f01529224e52af4
Author: P. Taylor Goetz <[email protected]>
Date: 2014-06-13T18:01:32Z
STORM-352: fix logic for writing offsets to ZooKeeper
----
> [storm-kafka] PartitionManager does not save offsets to ZooKeeper
> -----------------------------------------------------------------
>
> Key: STORM-352
> URL: https://issues.apache.org/jira/browse/STORM-352
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Affects Versions: 0.9.2-incubating
> Reporter: P. Taylor Goetz
> Assignee: P. Taylor Goetz
> Labels: kafka
>
> The logic to determine whether offsets should be written to ZK is wrong. As a
> result, offsets are never saved.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
