[
https://issues.apache.org/jira/browse/STORM-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034616#comment-14034616
]
ASF GitHub Bot commented on STORM-266:
--------------------------------------
GitHub user Parth-Brahmbhatt opened a pull request:
https://github.com/apache/incubator-storm/pull/146
STORM-266: Adding shell process pid and name in the log message and pid,...
...name,exitcode and stderr in case te shell process encounters error.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Parth-Brahmbhatt/incubator-storm STORM-266
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/146.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #146
----
commit 0c43a37f000298af17a11b6fe6e78dbb35e27ee8
Author: Parth Brahmbhatt <[email protected]>
Date: 2014-06-17T22:13:36Z
STORM-266: Adding shell process pid and name in the log message and
pid,name,exitcode and stderr in case te shell process encounters error.
----
> Improve debuggability of ShellBolt and ShellSpout
> -------------------------------------------------
>
> Key: STORM-266
> URL: https://issues.apache.org/jira/browse/STORM-266
> Project: Apache Storm (Incubating)
> Issue Type: Improvement
> Reporter: Robert Joseph Evans
>
> ShellBolt and ShellSpout are sometimes difficult to debug, especially when
> there are multiple instances running in under the same worker. It would be
> good to include the name of the bolt/spout in the logged messages, and
> probably the PID of the sub process too.
> In the case of errors it would be good for ShellProcess to try
> and get the exit code for the process, up to a timeout, and then get the
> contents of stderr. Also in the case of errors when wrapping the exceptions
> we probably want to include the name of the bolt/spout and the PID in the
> Exception message.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
