Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/150#discussion_r14034358
  
    --- Diff: storm-core/src/clj/backtype/storm/ui/core.clj ---
    @@ -291,6 +290,30 @@
            (map nil-to-zero)
            (apply max)))
     
    +(defn get-error-span [error]
    --- End diff --
    
    For these new functions could we follow the new convention with the 
parameters on the second line and put the closing ')' on the line with the last 
code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to