[
https://issues.apache.org/jira/browse/STORM-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039204#comment-14039204
]
ASF GitHub Bot commented on STORM-360:
--------------------------------------
Github user d2r commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/150#discussion_r14036506
--- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj ---
@@ -857,7 +857,10 @@
(defn- get-errors [storm-cluster-state storm-id component-id]
(->> (.errors storm-cluster-state storm-id component-id)
- (map #(ErrorInfo. (:error %) (:time-secs %)))))
+ (map #(let [error-info (ErrorInfo. (:error %) (:time-secs %))
+ _ (.set_host error-info (:host %))
+ _ (.set_port error-info (:port %))]
+ error-info))))
--- End diff --
Could we use doto instead?
```
(defn- get-errors [storm-cluster-state storm-id component-id]
(->> (.errors storm-cluster-state storm-id component-id)
(map #(doto (ErrorInfo. (:error %) (:time-secs %))
(.set_host (:host %))
(.set_port (:port %))))))
```
> Add woker-id/host info/port info to the error for easy tracking on UI
> ---------------------------------------------------------------------
>
> Key: STORM-360
> URL: https://issues.apache.org/jira/browse/STORM-360
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Reporter: Kishor Patil
> Labels: master
>
> As the ErrorInfo get from nimbus has no detailed information of where did
> this error happen. Can task id host/port for can be added to the error
> information? It can easy storm debug. Currently we also can only see the
> error information in UI but cannot which component throws this exception and
> track it to logs.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
