Github user d2r commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/160#discussion_r14150233
--- Diff: storm-core/src/ui/public/component.html ---
@@ -73,22 +73,32 @@
componentSummary.append(Mustache.render($(template).filter("#component-summary-template").html(),response));
if(response["componentType"] == "spout") {
componentStatsDetail.append(Mustache.render($(template).filter("#spout-stats-detail-template").html(),response));
- $("#spout-stats-table").tablesorter({ sortList: [[0,0]],
headers: {0: { sorter: "stormtimestr"}}});
+ if(response["spoutSummary"].length > 0) {
+ $("#spout-stats-table").tablesorter({ sortList:
[[0,0]], headers: {0: { sorter: "stormtimestr"}}});
+ }
outputStats.append(Mustache.render($(template).filter("#output-stats-template").html(),response));
- $("#output-stats-table").tablesorter({ sortList: [[0,0]],
headers: {0: { sorter: "stormtimestr"}}});
+ if(response["outputStats"].length > 0) {
+ $("#output-stats-table").tablesorter({ sortList:
[[0,0]], headers: {0: { sorter: "stormtimestr"}}});
+ }
executorStats.append(Mustache.render($(template).filter("#executor-stats-template").html(),response));
- $("#executor-stats-table").tablesorter({ sortList:
[[0,0]], headers: {1: { sorter: "stormtimestr"}}});
+ if(response["executorStats"].length > 0) {
+ $("#executor-stats-table").tablesorter({ sortList:
[[0,0]], headers: {1: { sorter: "stormtimestr"}}});
+ }
} else {
componentStatsDetail.append(Mustache.render($(template).filter("#bolt-stats-template").html(),response));
- $("#bolt-stats-table").tablesorter({ sortList: [[0,0]],
headers: {0: { sorter: "stormtimestr"}}});
+ if(response["boltStats"].length > 0) {
+ $("#bolt-stats-table").tablesorter({ sortList:
[[0,0]], headers: {0: { sorter: "stormtimestr"}}});
+ }
inputStats.append(Mustache.render($(template).filter("#bolt-input-stats-template").html(),response));
if (response["inputStats"].length > 0) {
$("#bolt-input-stats-table").tablesorter({ sortList:
[[0,0]], headers: {}});
}
outputStats.append(Mustache.render($(template).filter("#bolt-output-stats-template").html(),response));
- $("#bolt-output-stats-table").tablesorter({ sortList:
[[0,0]], headers: {}});
-
executorStats.append(Mustache.render($(template).filter("#bolt-executor-template").html(),response));
if(response["outputStats"].length > 0) {
+ $("#bolt-output-stats-table").tablesorter({ sortList:
[[0,0]], headers: {}});
+ }
+
executorStats.append(Mustache.render($(template).filter("#bolt-executor-template").html(),response));
+ if(response["executorStats"].length > 0) {
--- End diff --
Most of these changes look like additions of conditional checks, but this
one looks like we changed the key in `response` that is actually being checked.
Formerly, we checked `outputStats` before sorting `#bolt-executor-table`.
After the change, we check `executorStats` before sorting
`#bolt-executor-table`.
Was the key incorrect before the change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
