Github user nathanmarz commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/167#discussion_r14314682
--- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
@@ -297,7 +307,10 @@
^ISupervisor isupervisor (:isupervisor supervisor)
^LocalState local-state (:local-state supervisor)
sync-callback (fn [& ignored] (.add event-manager this))
- assignments-snapshot (assignments-snapshot storm-cluster-state
sync-callback)
+ assignment-versions (.get local-state LS-ASSIGNMENT-VERSIONS)
--- End diff --
This shouldn't be stored in the local state as there is no need to. Just
keep this information purely in memory. It's ok if the supervisor has to
re-download everything on death because deaths are rare. Persisted state should
be minimized as a general rule.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
