[ 
https://issues.apache.org/jira/browse/STORM-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048810#comment-14048810
 ] 

ASF GitHub Bot commented on STORM-381:
--------------------------------------

GitHub user HeartSaVioR opened a pull request:

    https://github.com/apache/incubator-storm/pull/174

    STORM-381 Replace broken jquery.tablesorter.min.js to latest

    It's related to https://issues.apache.org/jira/browse/STORM-381.
    
    This PR replaces broken tablesorter file to latest, so it resolves syntax 
error on it.
    
    * from https://github.com/Mottie/tablesorter
    * Version: 2.17.3
    * Link: 
https://github.com/Mottie/tablesorter/raw/master/js/jquery.tablesorter.min.js
    
    I just copy file and replace it, so comment related to copyright didn't 
deleted.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HeartSaVioR/incubator-storm master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-storm/pull/174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #174
    
----
commit 8f3ed521e17cdd544d89b529130d102eb43fa11f
Author: Jungtaek Lim <[email protected]>
Date:   2014-07-01T12:24:31Z

    STORM-381 Replace broken jquery.tablesorter.min.js to latest
    
    * from https://github.com/Mottie/tablesorter
    * Version: 2.17.3
    * Link: 
https://github.com/Mottie/tablesorter/raw/master/js/jquery.tablesorter.min.js

----


> Replace broken jquery.tablesorter.min.js to latest (2.17.3)
> -----------------------------------------------------------
>
>                 Key: STORM-381
>                 URL: https://issues.apache.org/jira/browse/STORM-381
>             Project: Apache Storm (Incubating)
>          Issue Type: Bug
>    Affects Versions: 0.9.2-incubating
>            Reporter: Jungtaek Lim
>
> We're having issue on Storm 0.9.2-incubating, javascript error from Storm UI.
> (It's already issued : STORM-379)
> It's syntax error from jquery.tablesorter.min.js,
> I'm not familiar with javascript, so I've just replaced it to latest version 
> (2.17.3), and it works!
> I don't have strong reason to use latest version, just resolve problem.
> So reviewers have a reason or issue to not use latest version, surely it can 
> be changed.
> I'll make pull request to continue working on it.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to