Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/117#discussion_r14422509
  
    --- Diff: bin/storm ---
    @@ -390,6 +390,19 @@ def print_classpath():
         """
         print get_classpath([])
     
    +def monitor(*args):
    +    """Syntax: [storm monitor [-i interval-secs] -t topology-name -m 
component-id [-s stream-id] [-w [emitted | transferred]]*]
    --- End diff --
    
    I would prefer to see topology-name be an argument not an option.  It 
matches better with the other commands list kill and rebalance.
    
    I would love it if we could make component-id optional, so that it would do 
one line per component if not supplied, or if you could do a list of component 
ids.
    
    And I'm not sure that we want a '*' after the '[emitted | transferred]' to 
me that means that you can supply 0 or more of them, but the reality is only 
the last one will be used like stream-id. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to