[ 
https://issues.apache.org/jira/browse/STORM-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049183#comment-14049183
 ] 

ASF GitHub Bot commented on STORM-312:
--------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/117#discussion_r14422509
  
    --- Diff: bin/storm ---
    @@ -390,6 +390,19 @@ def print_classpath():
         """
         print get_classpath([])
     
    +def monitor(*args):
    +    """Syntax: [storm monitor [-i interval-secs] -t topology-name -m 
component-id [-s stream-id] [-w [emitted | transferred]]*]
    --- End diff --
    
    I would prefer to see topology-name be an argument not an option.  It 
matches better with the other commands list kill and rebalance.
    
    I would love it if we could make component-id optional, so that it would do 
one line per component if not supplied, or if you could do a list of component 
ids.
    
    And I'm not sure that we want a '*' after the '[emitted | transferred]' to 
me that means that you can supply 0 or more of them, but the reality is only 
the last one will be used like stream-id. 


> 'storm monitor' to monitor throughput performance interactively
> ---------------------------------------------------------------
>
>                 Key: STORM-312
>                 URL: https://issues.apache.org/jira/browse/STORM-312
>             Project: Apache Storm (Incubating)
>          Issue Type: New Feature
>            Reporter: Jiahong Li
>              Labels: cmd-line-monitor
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> This cmd line tool 'storm monitor' will use Nimbus.Client to get throughput 
> information from Nimbus Server.
> 1)One can specify topology's name, component's name to monitor it's 
> throughput interactively.
> 2) It will statistics 'emit' and/or 'transferred' throughput in a given time 
> window and print it in a given time frequency
> The implementation will be much like yahoo's storm-perf-test 
> (http://yahooeng.tumblr.com/post/64758709722/making-storm-fly-with-netty) 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to