Github user revans2 commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/117#discussion_r14821664
--- Diff: storm-core/src/jvm/backtype/storm/utils/Monitor.java ---
@@ -0,0 +1,211 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package backtype.storm.utils;
+
+import backtype.storm.generated.*;
+
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+
+public class Monitor {
+ private static final String WATCH_TRANSFERRED = "transferred";
+ private static final String WATCH_EMITTED = "emitted";
+
+ private int _interval = 4;
+ private String _topology;
+ private String _component;
+ private String _stream;
+ private String _watch;
+
+ private static class MetricsState {
--- End diff --
I'm not sure we need agents as the code is not currently multi-threaded.
Threads feel like they would be an unneeded complication. I do agree that the
code could be a lot more concise in Clojure, but I personally don't see a
reason to rewrite it at this point. If someone wants to, especially to start
learning Clojure, then sure go right ahead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
