Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/187#discussion_r14850130
--- Diff: storm-core/test/clj/backtype/storm/config_test.clj ---
@@ -65,13 +65,41 @@
(.validateField validator "test" x)
(catch Exception e e)))))))
-(deftest test-topology-workers-is-number
+(deftest test-integer-validator
+ (let [validator ConfigValidation/IntegerValidator]
+ (.validateField validator "test" 1000)
+ (is (thrown-cause? java.lang.IllegalArgumentException
+ (.validateField validator "test" 1.34)))
+ (is (thrown-cause? java.lang.IllegalArgumentException
+ (.validateField validator "test" 9223372036854775807)))))
--- End diff --
@d2r I replaced magic numbers to actual meaning.
It would be more easy to understand. Thank you for comment!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
