[
https://issues.apache.org/jira/browse/STORM-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059546#comment-14059546
]
ASF GitHub Bot commented on STORM-328:
--------------------------------------
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/187#discussion_r14850130
--- Diff: storm-core/test/clj/backtype/storm/config_test.clj ---
@@ -65,13 +65,41 @@
(.validateField validator "test" x)
(catch Exception e e)))))))
-(deftest test-topology-workers-is-number
+(deftest test-integer-validator
+ (let [validator ConfigValidation/IntegerValidator]
+ (.validateField validator "test" 1000)
+ (is (thrown-cause? java.lang.IllegalArgumentException
+ (.validateField validator "test" 1.34)))
+ (is (thrown-cause? java.lang.IllegalArgumentException
+ (.validateField validator "test" 9223372036854775807)))))
--- End diff --
@d2r I replaced magic numbers to actual meaning.
It would be more easy to understand. Thank you for comment!
> Config.java and Utils.get{Int,Long} are not in sync for floating point
> ----------------------------------------------------------------------
>
> Key: STORM-328
> URL: https://issues.apache.org/jira/browse/STORM-328
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Affects Versions: 0.9.2-incubating, 0.9.1-incubating, 0.9.0.1
> Reporter: Robert Joseph Evans
> Labels: newbie
>
> For most numeric configuration values Config.java has a type of Number
> listed, but the values are parsed using Utils.getInt or Utils.getLong, which
> means if someone gave a floating point number it would pass the
> ConfigValidation, but would blow up when it is used. This is most critical
> for values that Nimbus reads, but would be good to have them consistent
> everywhere.
> We should also check that getInt works properly for numbers that are larger
> then would fit in an integer.
> Either we need to update Utils to be more lenient when looking at doubles, or
> we need to make Config more strict, which may be difficult with the YAML and
> JSON parsing that happens, where ints are often converted into longs.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
