Github user Jens-G commented on the pull request:
https://github.com/apache/incubator-storm/pull/184#issuecomment-48871059
@kishorvpatil:
First of all, I really appreciate your work on this topic, and I will
commit the Thrift patch as soon as it passes the review.
> As you suggested, trivial hash function(always returning 0)
> could be used if that's generic implementation thrift should provide
No. You are misrepresenting my statement. I did not say "always return 0",
instead I said "try to improve your has function, because it is badly
implemented". [The typical way a hash function is built is by XOR-ing the
values like
this](http://stackoverflow.com/questions/4005318/how-to-implement-a-good-hash-function-in-python):
function hash() {
int value = 0;
value = value * 101 ^ foo.hash();
value = value * 101 ^ bar.hash();
value = value * 101 ^ baz.hash();
return value
}
If you would have read the links (especialy the SO one), you would have
found out. And please don't tell me that someone else made the mistake. **You**
are the one proposing the patch, so please take over some responsibility. You
are of course free to inform the original author about the improvements that
could be made to make his code better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
