[
https://issues.apache.org/jira/browse/STORM-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065583#comment-14065583
]
ASF GitHub Bot commented on STORM-373:
--------------------------------------
Github user d2r commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/164#discussion_r15085420
--- Diff: storm-core/src/jvm/backtype/storm/Config.java ---
@@ -469,7 +469,8 @@
/**
* The jvm opts provided to workers launched by this supervisor. All
"%ID%" substrings are replaced
- * with an identifier for this worker.
+ * with an identifier for this worker. Also, "%WORKER-ID%",
"%STORM-ID%" and "%WORKER-PORT%" are
+ * replaced with appropriate runtime values for this worker.
--- End diff --
Let's explain clearly what substitutions are happening.
ID -> port (for backward compatibility)
WORKER-PORT -> port
WORKER-ID -> worker id
STORM-ID -> topology's id.
> Provide Additional String substitutions for *.worker.childopts
> ---------------------------------------------------------------
>
> Key: STORM-373
> URL: https://issues.apache.org/jira/browse/STORM-373
> Project: Apache Storm (Incubating)
> Issue Type: Improvement
> Affects Versions: 0.9.2-incubating
> Reporter: Kishor Patil
> Labels: master
>
> As a storm application developer, I would like to name my GC log uniquely, so
> that the log is not blown away each time the worker restarts.
> Add %WORKER-ID% (worker-id) %STORM-ID% (storm-id) to the substitution
> whenlaunching the worker JVM.
--
This message was sent by Atlassian JIRA
(v6.2#6252)