[
https://issues.apache.org/jira/browse/STORM-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066329#comment-14066329
]
ASF GitHub Bot commented on STORM-354:
--------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/122#issuecomment-49430433
I am really sorry it has taken me so long to review things. The changes
look good I am +1, I had to do an upmerge, because of whitespace issues due to
a reformatting patch that went in previously.
I'll merge this into master
> Allow users to pass TEST-TIMEOUT-MS as param for complete-topology
> ------------------------------------------------------------------
>
> Key: STORM-354
> URL: https://issues.apache.org/jira/browse/STORM-354
> Project: Apache Storm (Incubating)
> Issue Type: Improvement
> Affects Versions: 0.9.2-incubating
> Reporter: Aaron Levin
> Priority: Minor
> Labels: test
> Fix For: 0.9.2-incubating
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> It would be nice if complete-topology allowed a user to pass in the default
> timeout as a parameter (rather than just setting it as 5000ms). I had a test
> that kept failing by taking too long.
> This PR adds functionality without breaking any existing code. Tests pass.
> (PS - not sure if this is the proper way to submit a PR for an apache
> project. I'm open to feedback. Thanks)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
