Github user dashengju commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/196#discussion_r15148217
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -158,6 +157,33 @@ private void querySubprocess() {
}
}
+ private void handleLog(ShellMsg shellMsg) {
+ String msg = shellMsg.getMsg();
+ msg = "ShellLog" + _process.getProcessInfoString() + msg;
--- End diff --
I have noticed the white space. Because _process.getProcessInfoString()
return a string with white space at begin and end, so I did not add white space
here.
And I think the best way is remove white space in
_process.getProcessInfoString()'s return, and add white space in here
explicitly, and I have change the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
