[
https://issues.apache.org/jira/browse/STORM-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074530#comment-14074530
]
ASF GitHub Bot commented on STORM-347:
--------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/166#issuecomment-50172155
Yes, feel free to do the merge on another JIRA. The code looks good.
There are a lot of white space changes to Config.java, but I don't think that
is too critical.
I would like to see ShellBasedUnixGroupsMapping drop the Unix in it's name.
Looks like it will work with Windows too. Also it would be good to have some
tests for this code. I am fine with some simple unit tests that look at the
groups code in isolation. I realize it may be hard to do this cleanly for
Windows/Unix etc, especially when you don't know what user is running the
tests. But perhaps just a sanity test that you can get something back without
it blowing up.
> (Security) authentication should allow for groups not just users
> ----------------------------------------------------------------
>
> Key: STORM-347
> URL: https://issues.apache.org/jira/browse/STORM-347
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Reporter: Robert Joseph Evans
> Assignee: Sriharsha Chintalapani
> Labels: security
>
> It would really be great if authentication for topology access, and the UI
> could support groups, not just users.
> It might be worth looking at some Hadoop code that already does things like
> this.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
