Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/205#issuecomment-50173838
That change looks simple enough. My only concern was with us calling
isConnected a lot on the channel, but looking at the code for it in 3.6.3.Final
for the socketChannel it looks like it is just checking a variable, so I think
it should be fine. I am +1 on the change, but want to give some more time for
others to comment/look at it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
