Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/128#discussion_r15555399
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/rotation/TimedRotationPolicy.java
---
@@ -0,0 +1,55 @@
+package org.apache.storm.hdfs.bolt.rotation;
+
+import backtype.storm.tuple.Tuple;
+
+public class TimedRotationPolicy implements FileRotationPolicy {
+
+ public static enum TimeUnit {
--- End diff --
Nothing more than personal preference. I just didn't like j.u.c.TimeUnit
API in this context. I thought it was more intuitive to allow users to specify
durations in fractions (e.g. 1.5 hours).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
