Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/202#issuecomment-50549920
The code looks good. The wrap/unwrap we can save for a later time. I had
some very minor merge conflicts and
storm-core/test/clj/backtype/storm/messaging/netty_unit_test.clj is failing for
me. It looks like it needs to have STORM-MESSAGING-NETTY-AUTHENTICATION false
added to all of the configs, as they are unit tests and don't pick up
defaults.yaml
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
