Github user revans2 commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/215#discussion_r15836462
--- Diff: storm-core/pom.xml ---
@@ -197,6 +201,21 @@
<scope>test</scope>
</dependency>
<dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-auth</artifactId>
--- End diff --
I'm not sure we want to pull this in directly to storm itself. Storm
already has a lot of dependencies and adding more seems to me like it could
pollute the user classpath. Looking at
https://github.com/apache/hadoop-common/blob/trunk/hadoop-common-project/hadoop-auth/pom.xml
it looks like this is going to add in javax.servlet:servlet-api,
commons-codec:commons-codec,
org.apache.directory.server:apacheds-kerberos-codec and
org.apache.hadoop:hadoop-annotations to the classpath. Possibly along with
some oddness with two versions of Jetty. org.mortbay.jetty:jetty and the
org.eclipse.jetty:jetty that you added in above too. I am OK with adding in new
dependencies, but I would like to understand better what really needs to be
here and what does not.
Ideally it would also be nice to separate out dependencies that are needed
for worker processes from everything else. But that is probably a separate
JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
