Github user d2r commented on the pull request:
https://github.com/apache/incubator-storm/pull/36#issuecomment-51810642
> @d2r , a unit test test-sort-slots is added for sort-slots function. By
the way, (sort-by count ...) in last commit get a reverse result so I changed
it to the sort as you suggested.
I think this will work (giving `>` function as the third argument).
```Clojure
(sort-by count > (vals (group-by first all-slots)))
```
> The new test-sort-slots runs ok but another case testing4j-test fails. I
can not find any relationship between this test and the sort-slots code
changes. I roll back the sort-slots and testing4j-test still fails, so it
should be something wrong in the master branch.
I tried running tests on master and on your branch, but I did not see any
tests fail.
I did notice that the final assertion in this PR passes even without any
code change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
