Github user d2r commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/223#discussion_r16433290
--- Diff: storm-core/src/jvm/backtype/storm/task/ShellBolt.java ---
@@ -293,11 +295,13 @@ private void handleMetrics(ShellMsg shellMsg) {
}
private void die(Throwable exception) {
- String processInfo = _process.getProcessInfoString() +
_process.getProcessTerminationInfoString();
- _exception = new RuntimeException(processInfo, exception);
- LOG.error("Halting process: ShellBolt died.", exception);
- _collector.reportError(exception);
- System.exit(11);
+ if (_running) { //Don't exit if running tests
--- End diff --
Let's change the comment to me non-specific to tests. If we aren't
running, don't bother.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
