[
https://issues.apache.org/jira/browse/STORM-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102833#comment-14102833
]
Nathan Marz commented on STORM-461:
-----------------------------------
When was halt-process! changed to exit-process!, and why? The reason halt was
used in the first place was because in some situations exit won't always
shutdown the process, so it's much safer to use halt and minimize the chance of
having a living process that's supposed to be dead but in an unknown state.
> exit-process! does not always exit the process, but throws an exception
> instead
> -------------------------------------------------------------------------------
>
> Key: STORM-461
> URL: https://issues.apache.org/jira/browse/STORM-461
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Priority: Critical
>
> I'll try to put up a pull request shortly.
> ```
> diff --git a/storm-core/src/clj/backtype/storm/util.clj
> b/storm-core/src/clj/backtype/storm/util.clj
> index 7bd4991..398584f 100644
> --- a/storm-core/src/clj/backtype/storm/util.clj
> +++ b/storm-core/src/clj/backtype/storm/util.clj
> @@ -316,7 +316,7 @@
>
> (defn exit-process!
> [val & msg]
> - (log-error (RuntimeException. msg) "Halting process: " msg)
> + (log-error (RuntimeException. (str msg)) "Halting process: " msg)
> (.exit (Runtime/getRuntime) val))
> ```
--
This message was sent by Atlassian JIRA
(v6.2#6252)
