GitHub user rick-kilgore opened a pull request:
https://github.com/apache/incubator-storm/pull/238
don't discard unfinished messages that are not old
the ack() message in PartitionManager appears to have a bug that will
cause it to discard messages that have not been acknowledged even though
they have not fallen behind by maxOffsetBehind.
This can happen if there is at least one message that _is_ behind by
maxOffsetBehind. The code correctly identifies that one or more
messages in _pending are old, but then potentially discards some that
are not.
Note: I can't figure out how to run the automated tests on my laptop. I
get an error like this:
java.lang.RuntimeException: backtype.storm.multilang.NoOutputException:
Pipe to subprocess seems to be broken! No output read.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rick-kilgore/incubator-storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/238.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #238
----
commit 4da836f251fad76eb9cd3c0ed6a7bb60289ebf42
Author: Rick Kilgore <[email protected]>
Date: 2014-08-21T00:57:47Z
don't discard unfinished messages that are not old
the ack() message in PartitionManager appears to have a bug that will
cause it to discard messages that have not been acknowledged even though
they have not fallen behind by maxOffsetBehind.
This can happen if there is at least one message that _is_ behind by
maxOffsetBehind. The code correctly identifies that one or more
messages in _pending are old, but then potentially discards some that
are not.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
