[ 
https://issues.apache.org/jira/browse/STORM-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14109604#comment-14109604
 ] 

ASF GitHub Bot commented on STORM-472:
--------------------------------------

Github user revans2 commented on the pull request:

    https://github.com/apache/incubator-storm/pull/239#issuecomment-53315679
  
    Oh I saw STORM-472 go by, so I guess we get to have the discussion later.  
Thanks for the patch.  and keep up the good work.


> Non-completeable tests should receive an error message showing which spout is 
> incomplete
> ----------------------------------------------------------------------------------------
>
>                 Key: STORM-472
>                 URL: https://issues.apache.org/jira/browse/STORM-472
>             Project: Apache Storm (Incubating)
>          Issue Type: Bug
>    Affects Versions: 0.9.3-incubating
>            Reporter: Dave Golombek
>            Priority: Trivial
>
> When testing with a spout that is not-complete, an exception is raised saying 
> "Cannot complete topology unless every spout is a CompletableSpout (or mocked 
> to be)", which is descriptive, but it leaves it unclear which spout is at 
> fault. 
> I submitted a fix at https://github.com/apache/incubator-storm/pull/239



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to