[
https://issues.apache.org/jira/browse/STORM-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113375#comment-14113375
]
ASF GitHub Bot commented on STORM-330:
--------------------------------------
Github user kishorvpatil commented on the pull request:
https://github.com/apache/incubator-storm/pull/220#issuecomment-53676020
@revans2,
I have addressed all the concerns and all tests pass now.
- `backtype.storm.utils-test test-new-curator-uses-exponential-backoff`
exposed `getMaxRetryInterval` for testing alone. Since the `maxRetryInterval`
is argument passed in constructor and need not again be retrieved for assertion
against what was passed to the constructor.
- About failing tests, the constructor arguments needed to be corrected,
since old class had different order of `maxRetries` and `maxSleepTimeMs` in
`Utils.java`.
- About `divide by zero`, was scenarios I overlooked - when `maxRetries`
is below `expRetriesThreshold`, making the RetryPolicy - exponential only. In
that case, the calculation of `linearBaseSleepMs` failed. Now I am forcing it
to `1` whenever user configures `maxRetries` below exponential retry threshold.
> storm.messaging.netty.max_retries option in config file not being used if > 30
> ------------------------------------------------------------------------------
>
> Key: STORM-330
> URL: https://issues.apache.org/jira/browse/STORM-330
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Affects Versions: 0.9.1-incubating
> Reporter: Roland Jungnickel
> Priority: Minor
>
> I have been trying to set the storm.messaging.netty.max_retries to 240
> because of connection issues when one worker takes a longer time to start its
> processes. But due to this line
> https://github.com/apache/incubator-storm/blob/1a0b46e95ab4ac467525314a75819a75dec92c40/storm-core/src/jvm/backtype/storm/messaging/netty/Client.java#L73
> the max_retries is capped at 30. I am guessing this is a bug or at least
> should be noted somewhere in the documentation?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
