[
https://issues.apache.org/jira/browse/STORM-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113852#comment-14113852
]
ASF GitHub Bot commented on STORM-447:
--------------------------------------
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/219#discussion_r16846611
--- Diff: storm-core/pom.xml ---
@@ -288,6 +298,26 @@
<pattern>org.apache.thrift</pattern>
<shadedPattern>org.apache.thrift7</shadedPattern>
</relocation>
+ <relocation>
+ <pattern>org.jboss.netty</pattern>
+
<shadedPattern>org.apache.storm.netty</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>com.google.common</pattern>
+
<shadedPattern>org.apache.storm.guava</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>org.apache.http</pattern>
+
<shadedPattern>org.apache.storm.http</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>org.apache.zookeeper</pattern>
+
<shadedPattern>org.apache.storm.zookeeper</shadedPattern>
--- End diff --
@harshach Correct. The ZooKeeper classes are package-relocated and included
in the storm-core.jar.
> shade/relocate packages of dependencies that are common causes of dependency
> conflicts
> --------------------------------------------------------------------------------------
>
> Key: STORM-447
> URL: https://issues.apache.org/jira/browse/STORM-447
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Reporter: P. Taylor Goetz
> Assignee: P. Taylor Goetz
>
> A number of Storm's dependencies regularly conflict with user dependencies:
> * Netty (tends to conflict with Cassandra and others)
> * Guava
> * httpclient
> Shading these into storm-core.jar and doing package relocation will eliminate
> dependency conflicts when user code (topologies) depends on conflicting
> versions.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
