But I consider it a nice feature that I can use the storm dependencies directly (if I don't care about the specific version), as it means I don't have to worry about shipping the dependencies in my jar (and making it bigger). If the storm dependency version changes, I just update my code to use the new dependency version along with the new storm version...
I accept I'm probably in the minority here anyway... SimonC -----Original Message----- From: Bobby Evans [mailto:[email protected]] Sent: 28 August 2014 15:14 To: [email protected] Subject: Re: Consequences of STORM-447 Taylor is right, but pointing to the shaded versions means you are undoing what we have done to try and protect your from our dependency versions shifting out from under you. Can we change the pom we publish some how so that they are not listed as transitive dependencies any more? That way once they upgrade their storm dependency version maven should either start complaining that it cannot find the dependency, or if they have properly listed their own dependency, instead of relying on storm to provide it, it would just package the dependency in their jar. - Bobby On 8/28/14, 4:06 AM, "Simon Cooper" <[email protected]> wrote: >Excellent, thanks for the info! > >SimonC > >-----Original Message----- >From: P. Taylor Goetz [mailto:[email protected]] >Sent: 27 August 2014 18:40 >To: [email protected] >Subject: Re: Consequences of STORM-447 > >Naresh is correct. > >To use the bundled Storm versions of these dependencies, you simply >need to change import statements. > >-Taylor > >> On Aug 27, 2014, at 11:33 AM, Naresh Kosgi <[email protected]> >>wrote: >> >> I have not tried this yet but I think you might just need to change >>the way you import them. Instead of getting them from their regular >>package name you will need to import using the shade package name. I >>believe that should get it working if you are using the version >>provided by storm. >> >> >>> On Wed, Aug 27, 2014 at 11:23 AM, Jon Logan <[email protected]> >>>wrote: >>> >>> You should be able to put the jars in the lib/ directory of the >>> Storm install, on all machines, and then mark the dependency as >>> provided on your side. >>> >>> >>> On Wed, Aug 27, 2014 at 11:15 AM, Simon Cooper < >>> [email protected]> wrote: >>> >>>> I've just noticed STORM-447. We use several of storm's provided >>>> dependencies in our topology code (namely curator, guava, and >>>> zookeeper >>> via >>>> kafka). With this pull request, would we have to supply our own >>>> copy of these libraries in the topology jar? Would it be possible >>>> to still use storm's versions in our topology code to reduce the >>>> size of the uploaded jar? >>>> >>>> Thanks, >>>> SimonC >>>
