Github user d2r commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/177#discussion_r16907608
--- Diff: storm-core/test/clj/backtype/storm/multilang_test.clj ---
@@ -37,33 +37,32 @@
;; (Thread/sleep 10000)
;; )))
-(deftest test-multilang-rb
- (with-local-cluster [cluster :supervisors 4]
- (let [nimbus (:nimbus cluster)
- topology (thrift/mk-topology
- {"1" (thrift/mk-shell-spout-spec ["ruby"
"tester_spout.rb"] ["word"])}
- {"2" (thrift/mk-shell-bolt-spec {"1" :shuffle} "ruby"
"tester_bolt.rb" ["word"] :parallelism-hint 1)})]
- (submit-local-topology nimbus
- "test"
- {TOPOLOGY-WORKERS 20
TOPOLOGY-MESSAGE-TIMEOUT-SECS 3 TOPOLOGY-DEBUG true}
- topology)
- (Thread/sleep 10000)
- (.killTopology nimbus "test")
- (Thread/sleep 10000))))
+ (defn test-multilang
+ [executor file-extension]
+ (with-local-cluster [cluster :supervisors 4]
+ (let [nimbus (:nimbus cluster)
+ topology (thrift/mk-topology
+ {"1" (thrift/mk-shell-spout-spec [executor (str
"tester_spout." file-extension)] ["word"])}
+ {"2" (thrift/mk-shell-bolt-spec {"1" :shuffle} [executor
(str "tester_bolt." file-extension)] ["word"] :parallelism-hint 1)})]
+ (submit-local-topology nimbus
+ "test"
+ {TOPOLOGY-WORKERS 20 TOPOLOGY-MESSAGE-TIMEOUT-SECS 3
TOPOLOGY-DEBUG true}
+ topology)
+ (Thread/sleep 10000)
+ (.killTopology nimbus "test")
+ (Thread/sleep 10000)
+ )))
-(deftest test-multilang-py
- (with-local-cluster [cluster :supervisors 4]
- (let [nimbus (:nimbus cluster)
- topology (thrift/mk-topology
- {"1" (thrift/mk-shell-spout-spec ["python"
"tester_spout.py"] ["word"])}
- {"2" (thrift/mk-shell-bolt-spec {"1" :shuffle}
["python" "tester_bolt.py"] ["word"] :parallelism-hint 1)}
- )]
- (submit-local-topology nimbus
- "test"
- {TOPOLOGY-WORKERS 20
TOPOLOGY-MESSAGE-TIMEOUT-SECS 3 TOPOLOGY-DEBUG true}
- topology)
- (Thread/sleep 10000)
- (.killTopology nimbus "test")
- (Thread/sleep 10000)
- )))
+
+(deftest test-python
+(test-multilang "python" "py")
+)
--- End diff --
Can format as:
```Clojure
(deftest test-python
(test-multilang "python" "py"))
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
