[ 
https://issues.apache.org/jira/browse/STORM-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14115436#comment-14115436
 ] 

ASF GitHub Bot commented on STORM-386:
--------------------------------------

Github user d2r commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/177#discussion_r16907608
  
    --- Diff: storm-core/test/clj/backtype/storm/multilang_test.clj ---
    @@ -37,33 +37,32 @@
     ;;       (Thread/sleep 10000)
     ;;       )))
     
    -(deftest test-multilang-rb
    -  (with-local-cluster [cluster :supervisors 4]
    -    (let [nimbus (:nimbus cluster)
    -          topology (thrift/mk-topology
    -                    {"1" (thrift/mk-shell-spout-spec ["ruby" 
"tester_spout.rb"] ["word"])}
    -                    {"2" (thrift/mk-shell-bolt-spec {"1" :shuffle} "ruby" 
"tester_bolt.rb" ["word"] :parallelism-hint 1)})]
    -      (submit-local-topology nimbus
    -                             "test"
    -                             {TOPOLOGY-WORKERS 20 
TOPOLOGY-MESSAGE-TIMEOUT-SECS 3 TOPOLOGY-DEBUG true}
    -                             topology)
    -      (Thread/sleep 10000)
    -      (.killTopology nimbus "test")
    -      (Thread/sleep 10000))))
     
    + (defn test-multilang
    +       [executor file-extension]
    +       (with-local-cluster [cluster :supervisors 4]
    +         (let [nimbus (:nimbus cluster)
    +               topology (thrift/mk-topology
    +                  {"1" (thrift/mk-shell-spout-spec [executor (str 
"tester_spout." file-extension)] ["word"])}
    +                  {"2" (thrift/mk-shell-bolt-spec {"1" :shuffle} [executor 
(str "tester_bolt." file-extension)] ["word"] :parallelism-hint 1)})]
    +         (submit-local-topology nimbus
    +               "test"
    +               {TOPOLOGY-WORKERS 20 TOPOLOGY-MESSAGE-TIMEOUT-SECS 3 
TOPOLOGY-DEBUG true}
    +               topology)
    +       (Thread/sleep 10000)
    +       (.killTopology nimbus "test")
    +       (Thread/sleep 10000)
    +       )))
     
    -(deftest test-multilang-py
    -  (with-local-cluster [cluster :supervisors 4]
    -    (let [nimbus (:nimbus cluster)
    -          topology (thrift/mk-topology
    -                      {"1" (thrift/mk-shell-spout-spec ["python" 
"tester_spout.py"] ["word"])}
    -                      {"2" (thrift/mk-shell-bolt-spec {"1" :shuffle} 
["python" "tester_bolt.py"] ["word"] :parallelism-hint 1)}
    -                      )]
    -      (submit-local-topology nimbus
    -                          "test"
    -                          {TOPOLOGY-WORKERS 20 
TOPOLOGY-MESSAGE-TIMEOUT-SECS 3 TOPOLOGY-DEBUG true}
    -                          topology)
    -      (Thread/sleep 10000)
    -      (.killTopology nimbus "test")
    -      (Thread/sleep 10000)
    -      )))
    +
    +(deftest test-python
    +(test-multilang "python" "py")
    +)
    --- End diff --
    
    Can format as:
    ```Clojure
    (deftest test-python
      (test-multilang "python" "py"))
    ```


> Development of multilang protocol in nodejs
> -------------------------------------------
>
>                 Key: STORM-386
>                 URL: https://issues.apache.org/jira/browse/STORM-386
>             Project: Apache Storm (Incubating)
>          Issue Type: New Feature
>         Environment: nodejs
>            Reporter: Anya Tchernishov
>
> Support nodejs multilang protocol.
> Design considerations:
> - Emit will receive an object (like args and kwargs in python) and a callback 
> that is called when task ids list is received.
>             self.emit({tuple: [word]}, function(taskIds) {
>                 self.log(word + ' sent to task ids - ' + taskIds);
>             });
> - The following methods will received done method that must be invoked on 
> completion (same pattern used by the mocha test framework for async unit 
> tests). 
> - Internal implementation of emit uses Process.stdout.write without a 
> callback since nodejs streams maintain FIFO order (so far, we have not found 
> a need for providing a callback).
>   



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to