Github user ptgoetz commented on the pull request:

    https://github.com/apache/incubator-storm/pull/219#issuecomment-54369457
  
    @revans2 I just did a bunch of digging related to how the shade plugin 
handles dependencies. When a shaded artifact is installed or deployed to a 
maven repository, it is installed with the `dependency-reduced-pom.xml` instead 
of the original `pom.xml` it was built with. You have the choice of either 
removing shaded dependencies from the pom, or have them set to `provided` scope.
    
    Currently, our build is configured to set them to `provided` scope, which 
is actually not what we want, so we need to make the following change to the 
storm-core pom (which I've already done, just haven't pull requested it yet):
    
    ```
    <keepDependenciesWithProvidedScope>false</keepDependenciesWithProvidedScope>
    ```
    
    When maven builds a jar, it also puts the pom in 
`META-INF/${groupId}/${artifactId}/pom.xml`. In a shaded jar this will be the 
original pom, not the dependency reduced one. I'm not aware of any tools that 
use that pom, most use the pom that's in the maven repository. However, I do 
have a patched version of the shade plugin that will use the dependency reduced 
pom instead of the original if we need it.
    
    So long story short we should be able to flip that bit and avoid the 
scenarios you describe.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to