Github user revans2 commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/250#discussion_r17376755
--- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java ---
@@ -333,6 +348,27 @@ private void flushRequest(Channel channel, final
MessageBatch requests) {
if (requests == null)
return;
+ // Wait until the netty authentication completes
+ boolean isNettyAuth = (Boolean) this.storm_conf
+
.get(Config.STORM_MESSAGING_NETTY_AUTHENTICATION);
+ if (isNettyAuth && authenticatedSignal != null) {
+ try {
+ LOG.debug("sasl Waiting until the netty
authentication completes");
+ authenticatedSignal.await();
+ authenticatedSignal = null;
+ LOG.debug("sasl Netty authentication completed,
proceeding further");
+ } catch (InterruptedException e) {
+ LOG.error(
+ "failed to send requests to " +
remote_addr.toString()
+ + ": ",
e.getMessage());
--- End diff --
I think we just want e, not e.getMessage() here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
