rzo1 commented on code in PR #1720:
URL: https://github.com/apache/stormcrawler/pull/1720#discussion_r2530117550
##########
core/src/main/java/org/apache/stormcrawler/parse/DocumentFragmentBuilder.java:
##########
@@ -93,8 +94,9 @@ private void copyAttributes(org.jsoup.nodes.Node source,
Element el) {
for (Attribute attribute : source.attributes()) {
// valid xml attribute names are: ^[a-zA-Z_:][-a-zA-Z0-9_:.]
String key = attribute.getKey().replaceAll("[^-a-zA-Z0-9_:.]",
"");
Review Comment:
I guess the patterns below would be candidates for pre-compiled pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
