sigee commented on code in PR #1827:
URL: https://github.com/apache/stormcrawler/pull/1827#discussion_r2937287962
##########
core/src/test/java/org/apache/stormcrawler/MetadataTest.java:
##########
@@ -21,6 +21,33 @@
class MetadataTest {
+ @Test
+ void testCaseInsensitiveKeys() {
Review Comment:
Good work! One thing I'd push back on slightly: `testCaseInsensitiveKeys` is
doing a lot of work - it tests `getFirstValue`, `containsKey`, `addValue`, and
`remove` all in one go. If this test fails, it can take some digging to
identify which behavior broke.
Would you consider splitting it into separate test cases, each focused on a
single method?
- `testGetFirstValueIsCaseInsensitive`
- `testContainsKeyIsCaseInsensitive`
- `testAddValueIsCaseInsensitive`
- `testRemoveIsCaseInsensitive`
This keeps tests easier to read, maintain, and debug. Let me know your
thoughts!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
