sigee commented on code in PR #1834:
URL: https://github.com/apache/stormcrawler/pull/1834#discussion_r2970003809
##########
core/src/main/java/org/apache/stormcrawler/bolt/JSoupParserBolt.java:
##########
@@ -387,7 +387,7 @@ public void execute(Tuple tuple) {
return;
}
} catch (MalformedURLException e) {
- LOG.error("MalformedURLException on {}", url);
+ LOG.error("Exception on {}", url, e);
Review Comment:
As a broader follow-up: there are a few different patterns across the files
- some spots moved to a generic `Exception` catch + log, others kept
`MalformedURLException` but rephrased the log. Like LinkParseFilter.java#79.
Personally I’d prefer keeping the specific exception everywhere, since it
avoids accidentally swallowing unrelated errors and makes the intent more
explicit. Unless there’s a specific reason behind the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
