rzo1 opened a new pull request, #1863:
URL: https://github.com/apache/stormcrawler/pull/1863
The proxy race condition fix (`a08a456b`) introduced two regressions:
- The local builder for proxied requests lost:
- Default headers
- User-Agent
- A new `CloseableHttpClient` was created on every request, even when no
proxy was used
## Fixes applied
- Store `userAgent` and `defaultHeaders` as fields
- Pass these fields to the proxy builder
- Build the client once in `configure()` and reuse it for non-proxy requests
## Additional fixes
- Fix `toByteArray()` returning `null` when the entity input stream is
`null`
- Close the static `CONNECTION_MANAGER` in `cleanup()`
- Wrap the entity `InputStream` in a try-with-resources block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
