dpol1 commented on PR #1868:
URL: https://github.com/apache/stormcrawler/pull/1868#issuecomment-4186732680

   > thanks @dpol1 why not use the 3.x branch of OpenSearch since this is a 
complete rewrite? If this is to replace the older module in the future, we 
might as well start with whatever is the most recent. 
   
   Will do - I focused on the core logic first (`AsyncBulkProcessor` for 
buffers), the 3.x transport migration is next.
   
   > Are the archetypes and dashboards very different from the existing module? 
If not, I would be in favour of removing them from here - having duplicates is 
a pain. 
   
   They are identical to the existing module - removing them in this PR.
   
   > From a user's perspective all they will have to do is modify the name of 
the dependency
   
   Correct - the only change is the artifactId from `stormcrawler-opensearch` 
to `stormcrawler-opensearch-java`. The package path and all YAML config keys 
remain unchanged.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to