dpol1 commented on PR #1973: URL: https://github.com/apache/stormcrawler/pull/1973#issuecomment-4878286884
> Maybe I am making it more complicated than necessary. We can have some duplication initially, learn from it and make things more generic afterwards. yes, I'd wait too. `URLFrontier` is the only backend with a real blocking action today (`blockQueueUntil`); for OpenSearch or Solr I wouldn't even know what the action should be yet, so a shared base class now would end up designed around a single case. The pieces that would move to core are already isolated anyway: the parsing is in `RetryAfterParser`, and the 429/503 decision in `HostBlockBolt` is a static function with no gRPC in it. Whenever a second backend shows up it's a mechanical lift. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
