dpol1 commented on PR #1997:
URL: https://github.com/apache/stormcrawler/pull/1997#issuecomment-4969321805
Looks good overall! Just a couple of quick questions:
- `InetAddresses` comes from Guava: should `external/warc` declare it
directly instead of relying on the transitive dependency from core?
- Guava turns `::ffff:192.0.2.128` into IPv4. Is that intentional? Also,
the test comment should probably say “IPv4-mapped” rather than
“IPv4-compatible”.
- Maybe assert the final header value in a request/response test. This could
also be covered in #1998 if you plan to expand the WARC tests there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
