HarshDevelops opened a new pull request, #2006: URL: https://github.com/apache/stormcrawler/pull/2006
Thank you for contributing to Apache StormCrawler. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes - [x] Is there a issue associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with `#XXXX` where `XXXX` is the issue number you are trying to resolve? - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? - [x] Is the code properly formatted with `mvn git-code-format:format-code -Dgcf.globPattern="**/*" -Dskip.format.code=false`? ### For code changes - [ ] Have you ensured that the full suite of tests is executed via `mvn clean verify`? - [x] Have you written or updated unit tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file, including the main LICENSE file? - [x] If applicable, have you updated the NOTICE file, including the main NOTICE file? ### Note Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible. Closes #108 Summary: - Normalize known HTTP header metadata keys when hyphens are omitted or the header name is close to an existing `HttpHeaders` constant. - Add regression coverage for spellchecked HTTP header metadata and non-HTTP metadata keys. Testing: - `mvn -pl core -Dtest=MetadataTest test` - `mvn -pl core test` - `mvn git-code-format:format-code -Dgcf.globPattern="**/*" -Dskip.format.code=false` - `mvn --no-transfer-progress clean verify` reached `stormcrawler-opensearch`, then failed locally because Docker/Testcontainers was unavailable and skipped tests caused the module JaCoCo threshold to fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
