sebastian-nagel commented on code in PR #2034:
URL: https://github.com/apache/stormcrawler/pull/2034#discussion_r3682889569
##########
core/src/main/java/org/apache/stormcrawler/protocol/okhttp/HttpProtocol.java:
##########
@@ -686,6 +687,7 @@ public Response intercept(Interceptor.Chain chain) throws
IOException {
.header(ProtocolResponse.RESPONSE_IP_KEY, ipAddress)
.header(ProtocolResponse.REQUEST_TIME_KEY,
Long.toString(startFetchTime))
.header(ProtocolResponse.PROTOCOL_VERSIONS_KEY,
protocols.toString())
+ .header(ProtocolResponse.CIPHER_SUITES_KEY, cipherSuite)
Review Comment:
WARC writer checks for null anyway, because another protocol implementation
could have been used which does not collect the necessary information. If it's
not available, it does not add the `WARC-Cipher-Suite` header.
But I can change the code, so that no header is added, if no Cipher suite
was used (connection over http://).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
