rzo1 opened a new pull request, #2075: URL: https://github.com/apache/stormcrawler/pull/2075
`CookieConverter` only checked applicability for cookies carrying a `Domain` attribute. A cookie without one, which is the usual session cookie, skipped the check and was sent to whatever host was being fetched. The domain check also passed on exception and accepted a single-label `Domain` such as `com`. A three-argument `getCookies` taking the originating host is added and both protocol implementations use it. Neither records the host whose response set the cookie, so they pass null for now and a cookie that cannot be scoped is dropped rather than sent: with `http.use.cookies` enabled, host-only cookies stop going out until that host is recorded at fetch time. The two-argument method is deprecated and kept. Also corrects the `metadata.transfer` example in `internals.adoc`, which named `set-cookie` where the key is `protocol.set-cookie`. ### For all changes - [ ] Is there a issue associated with this PR? Is it referenced in the commit message? - no issue - [ ] Does your PR title start with `#XXXX` where `XXXX` is the issue number you are trying to resolve? - no issue - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? - [x] Is the code properly formatted with `mvn git-code-format:format-code -Dgcf.globPattern="**/*" -Dskip.format.code=false`? ### For code changes - [ ] Have you ensured that the full suite of tests is executed via `mvn clean verify`? - `core` module tests only - [x] Have you written or updated unit tests to verify your changes? - `CookieConverterTest` extended - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - no new dependencies - [x] If applicable, have you updated the LICENSE file, including the main LICENSE file? - n/a - [x] If applicable, have you updated the NOTICE file, including the main NOTICE file? - n/a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
