dpol1 commented on code in PR #2111:
URL: https://github.com/apache/stormcrawler/pull/2111#discussion_r3901642275
##########
core/src/main/java/org/apache/stormcrawler/parse/filter/CommaSeparatedToMultivaluedMetadata.java:
##########
@@ -60,9 +83,23 @@ public void filter(String url, byte[] content,
DocumentFragment doc, ParseResult
}
m.remove(key);
String[] tokens = val.split(" *, *");
+ if (tokens.length > maxTokens) {
Review Comment:
The cap runs before blanks are filtered, so with a low cap `,,,a` loses the
real token where the old code kept it - was that intended? Dropping blanks
first would avoid it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
