Riddhish1 commented on code in PR #2116:
URL: https://github.com/apache/stormcrawler/pull/2116#discussion_r3902120235
##########
external/tika/src/main/java/org/apache/stormcrawler/tika/ParserBolt.java:
##########
@@ -162,11 +162,32 @@ public void execute(Tuple tuple) {
// check that the mimetype is in the whitelist
if (!mimeTypeWhiteList.isEmpty()) {
boolean mt_match = false;
- // see if a mimetype was guessed in JSOUPBolt
+ // see if a mimetype was detected already (e.g. by JSoupParserBolt)
String mimeType = metadata.getFirstValue("parse.Content-Type");
Review Comment:
JSoupParserBolt.guessMimeType() does byte detection too (header is just a
hint) so basically the value is trustworthy in the standard topology, a custom
upstream writing a server copied value there would bypass it worth a comment
will add it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
